Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Buildkite did not pick up new env variable. #7403

Merged
merged 4 commits into from
Dec 13, 2023
Merged

[BUG] Buildkite did not pick up new env variable. #7403

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88d37c8
[BUG] Buildkite did not pick up new env variable.
1Copenut Dec 6, 2023
467f14e
Removing test env variable, leaving echo in place for now.
1Copenut Dec 6, 2023
042767c
Merge branch 'main' into bug/deploy-docs-manual-override-2
1Copenut Dec 7, 2023
a9f6dff
Passing env variable into Docker run call.
1Copenut Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .buildkite/scripts/lifecycle/pre_command.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,8 @@ export GCE_ACCOUNT
GITHUB_TOKEN=$(retry 5 vault read -field=github_token $GITHUB_ACCOUNT)
export GITHUB_TOKEN

GCE_IMAGE=google/cloud-sdk:slim
export GCE_IMAGE

GPROJECT=elastic-bekitzur
export GPROJECT
8 changes: 6 additions & 2 deletions scripts/deploy/deploy_docs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,16 @@ set +x
# Expected env variables:
# * GPROJECT - GCE project name, e.g. elastic-bekitzur
# * GCE_ACCOUNT - credentials for the google service account (JSON blob)
# * GCE_IMAGE - Google's Docker image to publish docs
# * GIT_BRANCH - current Git branch or tag (e.g. "refs/heads/main", "v18.2.1")
# * GIT_PULL_REQUEST_ID - current Git PR (Ex. 6999) or "false" from Buildkite env
# * GIT_TAG - current Git tag (Ex. v87.0.0) from Buildkite env
# * DEPLOY_ROOT - passed in from Buildkite UI to manually run release docs deployment

# Docker images
GCE_IMAGE=google/cloud-sdk:slim
# Test that DEPLOY_ROOT is being passed properly
# TODO: Revert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this get tested/reverted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did initially, but I'd like to keep it in the script until I get at least one successful manual run.

Having a quick way to verify the env variable before the build step in the Docker environment cuts my troubleshooting surface in half if it fails again.

echo "Testing deploy_root should be output"
echo ${DEPLOY_ROOT}

if [[ -z "${GPROJECT}" ]]; then
echo "GPROJECT is not set, e.g. 'GPROJECT=elastic-bekitzur'"
Expand Down
Loading