[BUG] Buildkite did not pick up new env variable. #7403
Conversation
|
it also might be here: eui/.buildkite/pipelines/pipeline_release_deploy_docs.yml Lines 7 to 10 in a744f40 when I triggered a manual deploy with custom |
On second glance I realize, I forgot to pass this env variable into the Docker env. Which explains why I could echo it in previous tests but the manual job failed. D'oh. |
| @@ -137,7 +141,7 @@ else | |||
|
|
|||
| # Our branched docs deploys are **only** ever triggered by tags | |||
| # https://buildkite.com/docs/pipelines/environment-variables#BUILDKITE_TAG | |||
| elif [[ ! -z "${GIT_TAG}" ]]; then | |||
| elif [[ -n "${GIT_TAG}" ]]; then | |||
There was a problem hiding this comment.
I changed this to -n on the recommendation from Shellcheck: https://www.shellcheck.net/wiki/SC2236
| @@ -103,6 +106,7 @@ if [[ "$1" != "nodocker" ]]; then | |||
| --env GIT_PULL_REQUEST_ID \ | |||
| --env GIT_TAG \ | |||
| --env CURRENT_RELEASE="${CURRENT_RELEASE}" \ | |||
| --env DEPLOY_ROOT="${DEPLOY_ROOT}" \ | |||
There was a problem hiding this comment.
Forgot to pass the env variable into Docker. I was able to echo it in previous tests but missed the key detail. This should run correctly now.
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @1Copenut |
| # Docker images | ||
| GCE_IMAGE=google/cloud-sdk:slim | ||
| # Test that DEPLOY_ROOT is being passed properly | ||
| # TODO: Revert |
There was a problem hiding this comment.
Did this get tested/reverted?
There was a problem hiding this comment.
It did initially, but I'd like to keep it in the script until I get at least one successful manual run.
Having a quick way to verify the env variable before the build step in the Docker environment cuts my troubleshooting surface in half if it fails again.
Summary
The new
DEPLOY_ROOTenv variable shipped in PR #7397 didn't get picked up in the test run I triggered manually. This PR will be a troubleshooting effort to determine if the variable didn't get passed to the shell script properly, or thecatalog-info.ymlneeds updated.QA
QA will be done manually, using the Buildkite UI to review environment variables, assert all jobs pass, and the deploy release docs runs correct when PR is merged.