Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Adding env var to trigger docs deploy manually from Buildkite UI #7397

Merged
merged 1 commit into from
Dec 6, 2023
Merged

[CHORE] Adding env var to trigger docs deploy manually from Buildkite UI #7397

merged 1 commit into from
Dec 6, 2023

Conversation

1Copenut
Copy link
Contributor

@1Copenut 1Copenut commented Dec 5, 2023

Summary

PR adds conditional logic to our deploy_docs shell script to listen for DEPLOY_ROOT env variable. If this variable is added to the release deploy docs job, it will trigger the build without pushing a new tag / release. PR closes #7396.

QA

Manually triggering the job assumes two key pieces of information:

  1. The job will be run against the main branch. Selected by default in Buildkite UI.
  2. The job will be run against the HEAD commit on main. Selected by default in Buildkite UI.

QA will be done in two parts, all in Buildkite:

  • Jobs must run correctly in PR
  • After PR is merged, I will trigger the job using Buildkite UI to pass in the new env variable and verify it runs correctly

@1Copenut
Copy link
Contributor Author

1Copenut commented Dec 5, 2023

Buildkite test this

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @1Copenut

Copy link
Member

@JasonStoltz JasonStoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No feedback here. I haven't tried it myself but I'll assume that it works as advertised and the instructions are accurate. I have no concerns with this approach.

@@ -45,7 +45,7 @@ post_comment_to_gh()
curl -s -L "https://api.github.com/repos/elastic/eui/issues/${GIT_PULL_REQUEST_ID}/comments" \
| jq -c '.[] | select(.user.login == "kibanamachine") | .id' \
)
for comment_id in ${kibanamachine_comment_ids[@]}; do
for comment_id in "${kibanamachine_comment_ids[@]}"; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look valid. I'm happy to approve this PR as is and test it in buildkite

@1Copenut 1Copenut marked this pull request as ready for review December 6, 2023 20:51
@1Copenut 1Copenut requested a review from a team as a code owner December 6, 2023 20:51
@1Copenut 1Copenut merged commit a6eb185 into elastic:main Dec 6, 2023
9 checks passed
@1Copenut 1Copenut deleted the feature/deploy-release-docs-override branch December 6, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE] Add an env variable to deploy root docs out of schedule
5 participants