-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Adding env var to trigger docs deploy manually from Buildkite UI #7397
[CHORE] Adding env var to trigger docs deploy manually from Buildkite UI #7397
Conversation
Buildkite test this |
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @1Copenut |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No feedback here. I haven't tried it myself but I'll assume that it works as advertised and the instructions are accurate. I have no concerns with this approach.
@@ -45,7 +45,7 @@ post_comment_to_gh() | |||
curl -s -L "https://api.github.com/repos/elastic/eui/issues/${GIT_PULL_REQUEST_ID}/comments" \ | |||
| jq -c '.[] | select(.user.login == "kibanamachine") | .id' \ | |||
) | |||
for comment_id in ${kibanamachine_comment_ids[@]}; do | |||
for comment_id in "${kibanamachine_comment_ids[@]}"; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look valid. I'm happy to approve this PR as is and test it in buildkite
Summary
PR adds conditional logic to our
deploy_docs
shell script to listen forDEPLOY_ROOT
env variable. If this variable is added to the release deploy docs job, it will trigger the build without pushing a new tag / release. PR closes #7396.QA
Manually triggering the job assumes two key pieces of information:
main
branch. Selected by default in Buildkite UI.HEAD
commit on main. Selected by default in Buildkite UI.QA will be done in two parts, all in Buildkite: