Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Bump Docker to use Node v20.9.0 #7379

Merged
merged 2 commits into from
Nov 21, 2023
Merged

[CHORE] Bump Docker to use Node v20.9.0 #7379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9060e5b
Bumping local Node and Docker image to v20.9.0.
1Copenut Nov 20, 2023
f8ed6ef
Removing Docker test scripts to be refactored in another PR.
1Copenut Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/scripts/pipelines/pipeline_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ DOCKER_OPTIONS=(
--user="$(id -u):$(id -g)"
--volume="$(pwd):/app"
--workdir=/app
docker.elastic.co/eui/ci:5.6
docker.elastic.co/eui/ci:6.0
)

case $TEST_TYPE in
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.18.2
20.9.0
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"main": "lib",
"module": "es",
"types": "eui.d.ts",
"docker_image": "18.18.2",
"docker_image": "20.9.0",
"engines": {
"node": "16.x || 18.x || >=20.0"
"node": "16.x || 18.x || >=20.x"
1Copenut marked this conversation as resolved.
Show resolved Hide resolved
},
"sideEffects": [
"*.css",
Expand Down
2 changes: 1 addition & 1 deletion scripts/deploy/build_docs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -e

NODE_IMG="docker.elastic.co/eui/ci:5.6"
NODE_IMG="docker.elastic.co/eui/ci:6.0"

# Compile using node image
echo "Building docs using ${NODE_IMG} Docker image"
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker-ci/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# https://github.com/zenato/docker-puppeteer/blob/master/Dockerfile

# >=12.0 required (for cypress). v18 is LTS.
FROM --platform=linux/amd64 node:18.18.2-slim
FROM --platform=linux/amd64 node:20.9.0-slim

SHELL ["/bin/bash", "-o", "pipefail", "-c"]

Expand Down
21 changes: 0 additions & 21 deletions scripts/test-a11y-docker.js
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions scripts/test-docker.js
View file
Open in desktop

This file was deleted.

Loading