Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Bump Docker to use Node v20.9.0 #7379

Merged
merged 2 commits into from
Nov 21, 2023
Merged

[CHORE] Bump Docker to use Node v20.9.0 #7379

merged 2 commits into from
Nov 21, 2023

Conversation

1Copenut
Copy link
Contributor

@1Copenut 1Copenut commented Nov 20, 2023

Summary

PR bumps our Docker Node image and daily driver Node to version 20.9.0 to match the Kibana team. PR closes #7378.

QA

  • QA will be verified manually on Buildkite UI. All PR jobs (tests and deploy docs) should pass with no issues.
  • Contributor has verified the following on their local machine:
    • nvm install 20.9.0
    • nvm alias default 20.9.0
    • yarn
    • yarn lint
    • yarn test-unit
    • yarn test-cypress
    • yarn storybook
  • For reviewers, please spot check the latest Node version on local machines
    • nvm install 20.9.0
    • nvm alias default 20.9.0
    • yarn
    • yarn lint
    • yarn test-unit
    • yarn test-cypress
    • yarn storybook

@1Copenut 1Copenut self-assigned this Nov 20, 2023
@1Copenut 1Copenut marked this pull request as ready for review November 20, 2023 23:21
@1Copenut 1Copenut requested a review from a team as a code owner November 20, 2023 23:21
@cee-chen
Copy link
Contributor

Oh snap! It just works? 🎉

Just for my own curiosity/edification, any idea what might have changed that prevented us from upgrading all the way to Node v20 when we last attempted in #6791 (comment)?

package.json Show resolved Hide resolved
scripts/test-docker.js Outdated Show resolved Hide resolved
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded and tested various scripts locally and everything's working great! I just have a few questions for you, but they're not blocking

@1Copenut
Copy link
Contributor Author

Just for my own curiosity/edification, any idea what might have changed that prevented us from upgrading all the way to Node v20 when we last attempted in #6791 (comment)?

I'm not sure, but if I had to guess the issue before was a config setting in my Intel-based machine OR an issue with legacy Node modules.

@cee-chen
Copy link
Contributor

cee-chen commented Nov 21, 2023

Snyk package upgrades could definitely have been the cause! Thanks Trevor, that answers all my questions - merge away whenever!

@1Copenut
Copy link
Contributor Author

Thanks @cee-chen! I added issue #7381 to rewrite the Docker test scripts. I'll merge and make an announcement when EUI is officially on Node 20.

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @1Copenut

@1Copenut 1Copenut merged commit 74cee6a into elastic:main Nov 21, 2023
1 check passed
@1Copenut 1Copenut deleted the chore/node-v20.9.0 branch November 21, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE] Bump Node to v20 to match Kibana
4 participants