-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Bump Docker to use Node v20.9.0 #7379
Conversation
Oh snap! It just works? 🎉 Just for my own curiosity/edification, any idea what might have changed that prevented us from upgrading all the way to Node v20 when we last attempted in #6791 (comment)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgraded and tested various scripts locally and everything's working great! I just have a few questions for you, but they're not blocking
I'm not sure, but if I had to guess the issue before was a config setting in my Intel-based machine OR an issue with legacy Node modules. |
Snyk package upgrades could definitely have been the cause! Thanks Trevor, that answers all my questions - merge away whenever! |
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @1Copenut |
Summary
PR bumps our Docker Node image and daily driver Node to version
20.9.0
to match the Kibana team. PR closes #7378.QA
nvm install 20.9.0
nvm alias default 20.9.0
yarn
yarn lint
yarn test-unit
yarn test-cypress
yarn storybook
nvm install 20.9.0
nvm alias default 20.9.0
yarn
yarn lint
yarn test-unit
yarn test-cypress
yarn storybook