Skip to content

Fix KeywordFieldMapperTests in non-snapshot build runs #137841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 12, 2025
Merged

Fix KeywordFieldMapperTests in non-snapshot build runs #137841

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba1ba59
Fix KeywordFieldMapperTests in non-snapshot build runs
romseygeek Nov 10, 2025
ff3edd3
Merge branch 'main' into test/keyword-field-mapper-failure
romseygeek Nov 11, 2025
2d6b191
Merge branch 'main' into test/keyword-field-mapper-failure
romseygeek Nov 11, 2025
d5cf4d5
Merge branch 'main' into test/keyword-field-mapper-failure
romseygeek Nov 12, 2025
10e1772
Merge branch 'main' into test/keyword-field-mapper-failure
romseygeek Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions server/src/test/java/org/elasticsearch/index/mapper/KeywordFieldMapperTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,7 @@ public void testFieldTypeWithSkipDocValues_LogsDbMode() throws IOException {
}));

final KeywordFieldMapper mapper = (KeywordFieldMapper) mapperService.documentMapper().mappers().getMapper("host.name");
if (IndexSettings.USE_DOC_VALUES_SKIPPER.get(settings)) {
if (mapperService.getIndexSettings().useDocValuesSkipper()) {
assertTrue(mapper.fieldType().hasDocValuesSkipper());
} else {
assertFalse(mapper.fieldType().hasDocValuesSkipper());
Expand Down Expand Up @@ -1038,7 +1038,7 @@ public void testFieldTypeDefault_ConfiguredIndexedWithSettingOverride() throws I

final KeywordFieldMapper mapper = (KeywordFieldMapper) mapperService.documentMapper().mappers().getMapper("host.name");
assertTrue(mapper.fieldType().hasDocValues());
if (IndexSettings.USE_DOC_VALUES_SKIPPER.get(settings)) {
if (mapperService.getIndexSettings().useDocValuesSkipper()) {
assertTrue(mapper.fieldType().hasDocValuesSkipper());
} else {
assertFalse(mapper.fieldType().hasDocValuesSkipper());
Expand All @@ -1060,7 +1060,7 @@ public void testFieldTypeDefault_ConfiguredIndexedWithoutSettingOverride() throw

final KeywordFieldMapper mapper = (KeywordFieldMapper) mapperService.documentMapper().mappers().getMapper("host.name");
assertTrue(mapper.fieldType().hasDocValues());
if (IndexSettings.USE_DOC_VALUES_SKIPPER.get(settings)) {
if (mapperService.getIndexSettings().useDocValuesSkipper()) {
assertTrue(mapper.fieldType().hasDocValuesSkipper());
} else {
assertFalse(mapper.fieldType().hasDocValuesSkipper());
Expand All @@ -1082,7 +1082,7 @@ public void testFieldTypeDefault_ConfiguredDocValues() throws IOException {

final KeywordFieldMapper mapper = (KeywordFieldMapper) mapperService.documentMapper().mappers().getMapper("host.name");
assertTrue(mapper.fieldType().hasDocValues());
if (IndexSettings.USE_DOC_VALUES_SKIPPER.get(settings)) {
if (mapperService.getIndexSettings().useDocValuesSkipper()) {
assertTrue(mapper.fieldType().hasDocValuesSkipper());
} else {
assertFalse(mapper.fieldType().hasDocValuesSkipper());
Expand Down Expand Up @@ -1122,7 +1122,7 @@ public void testFieldTypeWithSkipDocValues_IndexedFalseDocValuesTrue() throws IO

final KeywordFieldMapper mapper = (KeywordFieldMapper) mapperService.documentMapper().mappers().getMapper("host.name");
assertTrue(mapper.fieldType().hasDocValues());
if (IndexSettings.USE_DOC_VALUES_SKIPPER.get(settings)) {
if (mapperService.getIndexSettings().useDocValuesSkipper()) {
assertTrue(mapper.fieldType().hasDocValuesSkipper());
} else {
assertFalse(mapper.fieldType().hasDocValuesSkipper());
Expand Down