Fix KeywordFieldMapperTests in non-snapshot build runs #137841
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeywordFieldMapperTests was checking Settings directly for the presence of the USE_DOCVALUES_SKIPPERS flag, rather than going via IndexSettings.useDocValuesSkipper(), which meant that for non-snapshot builds the FeatureFlag was not being taken into account.
romseygeek
added
>test
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
romseygeek
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeywordFieldMapperTests was checking Settings directly for the presence
of the USE_DOCVALUES_SKIPPERS flag, rather than going via
IndexSettings.useDocValuesSkipper(), which meant that for non-snapshot
builds the FeatureFlag was not being taken into account.
Fixes #137826