Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync commits with dieharder-rgb repo #18

Merged
merged 7 commits into from
Jan 26, 2024

Conversation

mbroz
Copy link
Contributor

@mbroz mbroz commented Jan 26, 2024

As discussed i #17, these are missing committs from https://github.com/eddelbuettel/dieharder-rgb, changes by David Bauer.

Only trivial editing for clean patch apply (some build and warning fixes since that time), otherwise it shoudl be exact commits. (Other commits in log do not patch files present in this repo.)

I only quickly tested new tests 210, 211 (210 looks suspicious as it returns WEAK for /dev/urandom data... also the name is duplicate with test 0 - but this should be fixed later - rename to v2?)

Fixes: #17

@eddelbuettel
Copy link
Owner

Hm. #16 appears to have brought us into this century by adding CI which apparently worked at the time. Any idea what is wrong now? Changed autotools conventions maybe?

@mbroz
Copy link
Contributor Author

mbroz commented Jan 26, 2024

I do not think CI actually worked :-) It is "make distcheck" that requires some legacy svn thing, I would disable it for now (I'll try to do new commit once I can test it on my GitHub clone).

@eddelbuettel
Copy link
Owner

Agreed. I should at least take out make distcheck.

Do you think it is worth me doing a real quick commit and you then rebased off that?

@mbroz
Copy link
Contributor Author

mbroz commented Jan 26, 2024

I proposed PR #19 in the meantime.

@mbroz
Copy link
Contributor Author

mbroz commented Jan 26, 2024

(Rebased over PR #19, so merge this one first if it is ok. thx )

@eddelbuettel
Copy link
Owner

That works but we now have

This branch is 8 commits ahead of, 1 commit behind eddelbuettel/dieharder:master.

I could squash-merge for ease of it all.

Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for carrying these over from the other repo.

@mbroz
Copy link
Contributor Author

mbroz commented Jan 26, 2024

Hm , seems I forgt to sync my master branch. Should be ok now.

@eddelbuettel
Copy link
Owner

My head is a little fried but I think my act of merging constitutes a change you could not have anticipated so you always needed to rebase relative to my master. I may be wrong.

But we're good so double-thanks. Will merge this as is as it is thing of careful beauty.

@eddelbuettel eddelbuettel merged commit ea8ea11 into eddelbuettel:master Jan 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to dieharder-rgb git?
3 participants