159 fix issue when journaldocked message is missing landing pad info #160
Conversation
The method 'getLandingPads' in 'MybatisStationEntityMapper.java' was refactored to improve functionality when mapping landing pad sizes. A new private method 'filterLandingPads' was added for handling empty landing pad maps. Additionally, tests were expanded in 'MybatisStationEntityMapperTest.java' to cover conditions when station landing pads are empty or null.
The 'landingPadSizeFromPayload()' method in 'ReceiveJournalDockedService.java' has been updated to handle possibly null landing pads with the help of Optional. An Optional.ofNullable has been added to elegantly handle any potential null values of the payload's landing pads. This offers a more robust and foolproof way of mapping landing pad sizes.
There was a problem hiding this comment.
We had UNKNOWN as our standing for this enum. our database is currently loaded with UNKNOWN's. Just need to fix our enum, and database to account for these changes. We'll have to run a db update to convert all UNKOWN's to null.
I dont think this is unreasonable. it'd be weird to keep a stand-in for null, as we will have many null fields across our database and we should handle them the same.
These changes are for exploration module, not for trade. These changes have not impact on the trade, as trade will try to request this data. and is completely agnostic of how exploration stores this data |
pveeckhout
deleted the
159-fix-issue-when-journaldocked-message-is-missing-landing-pad-info
branch
fixes #159