Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue when JournalDocked message is missing landing pad info #159

Closed
pveeckhout opened this issue Mar 24, 2024 · 0 comments · Fixed by #160
Closed

fix issue when JournalDocked message is missing landing pad info #159

pveeckhout opened this issue Mar 24, 2024 · 0 comments · Fixed by #160
Assignees
@pveeckhout
Labels
bug Something isn't working

Comments

@pveeckhout
Copy link
Contributor

There is an issue with a message from JournalDocked where for some reason the landingPad info is omitted.

we need to strengthen the code base to handle this
@pveeckhout pveeckhout added the bug Something isn't working label Mar 24, 2024
@pveeckhout pveeckhout self-assigned this Mar 24, 2024
pveeckhout added a commit that referenced this issue Mar 24, 2024
@pveeckhout
#159 Refactor MybatisStationEntityMapper and expand tests
f365f0e 
The method 'getLandingPads' in 'MybatisStationEntityMapper.java' was refactored to improve functionality when mapping landing pad sizes. A new private method 'filterLandingPads' was added for handling empty landing pad maps. Additionally, tests were expanded in 'MybatisStationEntityMapperTest.java' to cover conditions when station landing pads are empty or null.
pveeckhout added a commit that referenced this issue Mar 24, 2024
@pveeckhout
#159 Add null-check to landingPadSizeFromPayload method
4e8180a 
The 'landingPadSizeFromPayload()' method in 'ReceiveJournalDockedService.java' has been updated to handle possibly null landing pads with the help of Optional. An Optional.ofNullable has been added to elegantly handle any potential null values of the payload's landing pads. This offers a more robust and foolproof way of mapping landing pad sizes.
@pveeckhout pveeckhout mentioned this issue Mar 24, 2024
Merged
@pveeckhout pveeckhout linked a pull request Mar 24, 2024 that will close this issue
159 fix issue when journaldocked message is missing landing pad info #160
Merged
pveeckhout added a commit that referenced this issue Mar 25, 2024
@pveeckhout
159 fix issue when journaldocked message is missing landing pad info (#…
2d47b01 
…160)

* #159 Refactor MybatisStationEntityMapper and expand tests

The method 'getLandingPads' in 'MybatisStationEntityMapper.java' was refactored to improve functionality when mapping landing pad sizes. A new private method 'filterLandingPads' was added for handling empty landing pad maps. Additionally, tests were expanded in 'MybatisStationEntityMapperTest.java' to cover conditions when station landing pads are empty or null.

* #159 Add null-check to landingPadSizeFromPayload method

The 'landingPadSizeFromPayload()' method in 'ReceiveJournalDockedService.java' has been updated to handle possibly null landing pads with the help of Optional. An Optional.ofNullable has been added to elegantly handle any potential null values of the payload's landing pads. This offers a more robust and foolproof way of mapping landing pad sizes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pveeckhout pveeckhout

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

159 fix issue when journaldocked message is missing landing pad info ed-pilots-network/backend
1 participant
@pveeckhout