lib/deflate_compress: use u32 for match length and offsets #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported at #416, deflate_compress.c is passing a pointer to unsigned int to a function that takes a pointer to u32. This is not compatible with unsigned int and u32 being different sizes, and was also reported to cause a compiler warning with arm-none-eabi-gcc (despite the types being the same size there). Let's just consistently use u32 for match lengths and offsets instead of unsigned int. This is suboptimal when sizeof(unsigned int) == 2, but that case seems to be fairly dead and libdeflate has never worked there anyway.
ebiggers
force-pushed
the
unsigned-int
branch
from
7fbb899 to
7b973b9
Compare
Owner
Author
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported at #416, deflate_compress.c is passing a pointer to unsigned int to a function that takes a pointer to u32. This is not compatible with unsigned int and u32 being different sizes, and was also reported to cause a compiler warning with arm-none-eabi-gcc (despite the types being the same size there).
Let's just consistently use u32 for match lengths and offsets instead of unsigned int. This is suboptimal when sizeof(unsigned int) == 2, but that case seems to be fairly dead and libdeflate has never worked there anyway.