Skip to content

Unify minimizer category and switchable-selector API surface #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewSazonov merged 83 commits into from
May 24, 2026

Update pixi dependencies

29baed1
Select commit
Loading
Failed to load commit list.
Merged

Unify minimizer category and switchable-selector API surface #180

Update pixi dependencies
29baed1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 24, 2026 in 0s

85.95% (+3.69%) compared to 883c384

View this Pull Request on Codecov

85.95% (+3.69%) compared to 883c384

Details

Codecov Report

❌ Patch coverage is 91.66097% with 122 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.95%. Comparing base (883c384) to head (29baed1).
⚠️ Report is 86 commits behind head on develop.

Files with missing lines Patch % Lines
...easydiffraction/datablocks/experiment/item/base.py 74.57% 21 Missing and 9 partials ⚠️
src/easydiffraction/project/display.py 51.28% 17 Missing and 2 partials ⚠️
src/easydiffraction/analysis/analysis.py 92.82% 9 Missing and 6 partials ⚠️
src/easydiffraction/io/cif/serialize.py 71.11% 6 Missing and 7 partials ⚠️
src/easydiffraction/io/results_sidecar.py 87.09% 6 Missing and 6 partials ⚠️
...asydiffraction/project/categories/table/default.py 83.92% 6 Missing and 3 partials ⚠️
...ydiffraction/analysis/categories/minimizer/base.py 89.13% 2 Missing and 3 partials ⚠️
...tion/datablocks/experiment/categories/peak/base.py 87.09% 3 Missing and 1 partial ⚠️
...asydiffraction/project/categories/chart/default.py 93.22% 3 Missing and 1 partial ⚠️
src/easydiffraction/display/plotting.py 0.00% 3 Missing ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #180      +/-   ##
===========================================
+ Coverage    82.26%   85.95%   +3.69%     
===========================================
  Files           88      206     +118     
  Lines         5451    15730   +10279     
  Branches       454     1827    +1373     
===========================================
+ Hits          4484    13521    +9037     
- Misses         802     1513     +711     
- Partials       165      696     +531
Files with missing lines Coverage Δ
src/easydiffraction/analysis/__init__.py 100.00% <100.00%> (ø)
...rc/easydiffraction/analysis/categories/__init__.py 100.00% <100.00%> (ø)
...tion/analysis/categories/fit_parameters/default.py 100.00% <100.00%> (ø)
...ction/analysis/categories/fitting_mode/__init__.py 100.00% <100.00%> (ø)
...action/analysis/categories/fitting_mode/default.py 100.00% <100.00%> (ø)
...action/analysis/categories/fitting_mode/factory.py 100.00% <100.00%> (ø)
...fraction/analysis/categories/minimizer/__init__.py 100.00% <100.00%> (ø)
...diffraction/analysis/categories/minimizer/bumps.py 100.00% <100.00%> (ø)
...tion/analysis/categories/minimizer/bumps_amoeba.py 100.00% <100.00%> (ø)
...fraction/analysis/categories/minimizer/bumps_de.py 100.00% <100.00%> (ø)
... and 53 more

... and 153 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov