Skip to content

Unify minimizer category and switchable-selector API surface#180

Merged
AndrewSazonov merged 83 commits into
developfrom
minimizer-category-consolidation
May 24, 2026
Merged

Unify minimizer category and switchable-selector API surface#180
AndrewSazonov merged 83 commits into
developfrom
minimizer-category-consolidation

Conversation

@AndrewSazonov
Copy link
Copy Markdown
Member

EasyDiffraction now uses the same compact shape everywhere the user picks an implementation — minimizer, peak profile, background, extinction correction, calculator backend, chart and table renderers, fitting mode.

@AndrewSazonov AndrewSazonov added the [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) label May 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

❌ Patch coverage is 91.66097% with 122 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.95%. Comparing base (883c384) to head (29baed1).
⚠️ Report is 86 commits behind head on develop.

Files with missing lines Patch % Lines
...easydiffraction/datablocks/experiment/item/base.py 74.57% 21 Missing and 9 partials ⚠️
src/easydiffraction/project/display.py 51.28% 17 Missing and 2 partials ⚠️
src/easydiffraction/analysis/analysis.py 92.82% 9 Missing and 6 partials ⚠️
src/easydiffraction/io/cif/serialize.py 71.11% 6 Missing and 7 partials ⚠️
src/easydiffraction/io/results_sidecar.py 87.09% 6 Missing and 6 partials ⚠️
...asydiffraction/project/categories/table/default.py 83.92% 6 Missing and 3 partials ⚠️
...ydiffraction/analysis/categories/minimizer/base.py 89.13% 2 Missing and 3 partials ⚠️
...tion/datablocks/experiment/categories/peak/base.py 87.09% 3 Missing and 1 partial ⚠️
...asydiffraction/project/categories/chart/default.py 93.22% 3 Missing and 1 partial ⚠️
src/easydiffraction/display/plotting.py 0.00% 3 Missing ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #180      +/-   ##
===========================================
+ Coverage    82.26%   85.95%   +3.69%     
===========================================
  Files           88      206     +118     
  Lines         5451    15730   +10279     
  Branches       454     1827    +1373     
===========================================
+ Hits          4484    13521    +9037     
- Misses         802     1513     +711     
- Partials       165      696     +531     
Flag Coverage Δ
integration 71.77% <84.14%> (+1.82%) ⬆️
unittests 78.81% <86.32%> (+6.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easydiffraction/analysis/__init__.py 100.00% <100.00%> (ø)
...rc/easydiffraction/analysis/categories/__init__.py 100.00% <100.00%> (ø)
...tion/analysis/categories/fit_parameters/default.py 100.00% <100.00%> (ø)
...ction/analysis/categories/fitting_mode/__init__.py 100.00% <100.00%> (ø)
...action/analysis/categories/fitting_mode/default.py 100.00% <100.00%> (ø)
...action/analysis/categories/fitting_mode/factory.py 100.00% <100.00%> (ø)
...fraction/analysis/categories/minimizer/__init__.py 100.00% <100.00%> (ø)
...diffraction/analysis/categories/minimizer/bumps.py 100.00% <100.00%> (ø)
...tion/analysis/categories/minimizer/bumps_amoeba.py 100.00% <100.00%> (ø)
...fraction/analysis/categories/minimizer/bumps_de.py 100.00% <100.00%> (ø)
... and 53 more

... and 153 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndrewSazonov AndrewSazonov merged commit 973214a into develop May 24, 2026
25 of 30 checks passed
@AndrewSazonov AndrewSazonov deleted the minimizer-category-consolidation branch June 1, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant