-
Notifications
You must be signed in to change notification settings - Fork 31
Add Web Notifications support #2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e5edc06
Add webNotifications feature for macOS
diegoreymendez 9f55e0a
Fix: Coerce notification options to strings for Swift decoding
diegoreymendez 5aab99c
Move webNotifications to webCompat setting
diegoreymendez 6b6a332
Add nativeEnabled setting and isSecureContext gate to webNotifications
diegoreymendez a84135f
Merge branch 'main' into diego/support-website-notifications
diegoreymendez f091fc8
Remove debug logging from webNotificationsFix
diegoreymendez 3a8dc54
Address PR feedback for webNotificationsFix
diegoreymendez cac0a60
Revert shimInterface change due to TypeScript constraints
diegoreymendez ac47e29
Use wrapFunction for Notification constructor, fix close() onclose ha…
diegoreymendez 1d73fba
Merge branch 'main' into diego/support-website-notifications
diegoreymendez 631608c
Update Notification.permission after requestPermission resolves
diegoreymendez a5993e5
Make close() idempotent to prevent multiple onclose events
diegoreymendez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
injected/src/messages/web-compat/closeNotification.notify.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "type": "object", | ||
| "title": "CloseNotificationParams", | ||
| "description": "Parameters for closing a web notification", | ||
| "additionalProperties": false, | ||
| "required": ["id"], | ||
| "properties": { | ||
| "id": { | ||
| "description": "Unique identifier of the notification to close", | ||
| "type": "string" | ||
| } | ||
| } | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.