Add Web Notifications support #2067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add web-notifications.js feature with Notification API polyfill - Add message schema for showNotification, closeNotification, requestPermission - Add unit tests - Register feature for apple platform - Add debug logging for feature loading
- Convert title, body, icon, tag to String() in constructor - Add tests for non-string option coercion - Ensures Swift Decodable can parse numeric tag values
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Mon, 01 Dec 2025 11:13:22 GMT Android
File has changed AppleFile has changed IntegrationFile has changed WindowsFile has changed |
diegoreymendez
changed the title
diegoreymendez
changed the title
- Add webNotificationsFix() to web-compat.js as independent setting - Move message definitions from web-notifications/ to web-compat/ - Remove webNotifications from standalone feature registration - Delete standalone web-notifications.js and types - Replace unit tests with integration tests in web-compat.spec.js - Regenerate web-compat.ts types for new messages
- Add isSecureContext check (crypto.randomUUID requires secure context) - Add nativeEnabled setting (defaults true, when false returns denied and skips native calls) - Add integration tests for nativeEnabled: false behavior
jonathanKingston
approved these changes
Nov 28, 2025
- Update secure context comment to clarify Notification API requirement - Replace wrapToString with shimInterface for consistent constructor wrapping
shimInterface requires full interface implementation including EventTarget, which is impractical for the Notification polyfill. Reverting to wrapToString.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1206580121312550/task/1212218453244516?focus=true
Description
Testing Steps
N/A - feature not available in any platform yet.
Checklist
Please tick all that apply:
Note
Introduces a Notification API polyfill that bridges to native for permissions/events, with new messaging schemas/types and comprehensive integration tests.
injected/src/features/web-compat.js):window.Notificationin secure contexts with constructor,permissiongetter (default/denied),maxActions,requestPermission, and event handlers (onshow,onclose,onclick,onerror).notify('showNotification' | 'closeNotification'),request('requestPermission'), andsubscribe('notificationEvent').close()firesoncloseonce; supportsnativeEnabled: falseto short-circuit todeniedwithout native calls.wrapFunctionusage and internal storage for notifications.injected/src/messages/web-compat/*.json):showNotification.notify,closeNotification.notify,requestPermission.request/response, andnotificationEvent.subscribemessage definitions.injected/src/types/web-compat.ts):WebCompatMessageswith new notifications/requests/subscriptions.WebCompatinterface to includenotifyandsubscribe.injected/integration-test/web-compat.spec.js):webNotificationssuites covering API exposure, permission flow updates, native error fallback, event handling,toStringshapes, message emission, and behavior whennativeEnabled: false.Written by Cursor Bugbot for commit a5993e5. This will update automatically on new commits. Configure here.