[Mono] Fix ParameterInfo.Name to return null for unnamed parameters #121105
+10
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Mono] Fix ParameterInfo.Name to return null for unnamed parameters
Summary
Fixes runtime inconsistency where Mono's
ParameterInfo.Namereturns empty string ("") for unnamed parameters while CoreCLR correctly returnsnull.Problem
Failing Tests:
OpenApiOperationGeneratorTests.ThrowsInvalidOperationExceptionGivenUnnamedParameterRequestDelegateFactoryTests.CreateThrowsInvalidOperationExceptionGivenUnnamedArgumentRoot Cause:
ASP.NET Core validation checks
if (parameter.Name is null)- this works on CoreCLR but fails on Mono.Reproduction
Test Results:
loader.cfix:param.Namestill returns""param.Namecorrectly returnsnullWhy
ParameterInfo.Nameis nullable (string?) per API Contract)Related Issues
Fixes failures in dotnet/aspnetcore test suite when running on Mono runtime.
cc: @giritrivedi