-
Notifications
You must be signed in to change notification settings - Fork 5k
Update Linux versions in CoreCLR pipeline #115757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
24ed3cb
Update Linux versions in CoreCLR pipeline
richlander b2d8e98
Update eng/pipelines/coreclr/templates/helix-queues-setup.yml
richlander 95e0a30
Update eng/pipelines/coreclr/templates/helix-queues-setup.yml
richlander 2f00378
Update eng/pipelines/coreclr/templates/helix-queues-setup.yml
richlander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,23 +63,23 @@ jobs: | |
| # Linux arm | ||
| - ${{ if eq(parameters.platform, 'linux_arm') }}: | ||
| - ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| - (Debian.12.Arm32.Open)[email protected]/dotnet-buildtools/prereqs:debian-12-helix-arm32v7 | ||
| - (Debian.13.Arm32.Open)[email protected]/dotnet-buildtools/prereqs:debian-13-helix-arm32v7 | ||
| - ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| - (Debian.12.Arm32)[email protected]/dotnet-buildtools/prereqs:debian-12-helix-arm32v7 | ||
| - (Debian.13.Arm32)[email protected]/dotnet-buildtools/prereqs:debian-13-helix-arm32v7 | ||
|
|
||
| # Linux arm64 | ||
| - ${{ if eq(parameters.platform, 'linux_arm64') }}: | ||
| - ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| - (Ubuntu.2404.Arm64.Open)Ubuntu.2204.Armarch[email protected]/dotnet-buildtools/prereqs:ubuntu-24.04-helix-arm64v8 | ||
| - (AzureLinux.3.0.ArmArch.Open)Ubuntu.2204.ArmArch[email protected]/dotnet-buildtools/prereqs:azurelinux-3.0-helix-arm64v8 | ||
| - ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| - (Ubuntu.2404.Arm64)[email protected]/dotnet-buildtools/prereqs:ubuntu-24.04-helix-arm64v8 | ||
| - (AzureLinux.3.0.ArmArch)[email protected]/dotnet-buildtools/prereqs:azurelinux-3.0-helix-arm64v8 | ||
|
|
||
| # Linux musl x64 | ||
| - ${{ if eq(parameters.platform, 'linux_musl_x64') }}: | ||
| - ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| - (Alpine.321.Amd64.Open)AzureLinux.3.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.21-helix-amd64 | ||
| - (Alpine.321.Amd64.Open)AzureLinux.3.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.21-helix-amd64 | ||
| - ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| - (Alpine.321.Amd64)AzureLinux.3.amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.21-helix-amd64 | ||
| - (Alpine.321.Amd64)AzureLinux.3.Amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.21-helix-amd64 | ||
richlander marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # Linux musl arm32 | ||
| - ${{ if eq(parameters.platform, 'linux_musl_arm') }}: | ||
|
|
@@ -105,9 +105,9 @@ jobs: | |
| # OSX arm64 | ||
| - ${{ if eq(parameters.platform, 'osx_arm64') }}: | ||
| - ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| - osx.13.arm64.open | ||
| - OSX.13.Arm64.Open | ||
| - ${{ if eq(variables['System.TeamProject'], 'internal') }}: | ||
| - OSX.1200.ARM64 | ||
| - OSX.1200.Arm64 | ||
|
|
||
| # OSX x64 | ||
| - ${{ if eq(parameters.platform, 'osx_x64') }}: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an AZ3 VM running on Ubuntu, or vice versa?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct. It's testing AL3. The display text is for the container image not the VM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean we are intentionally dropping testing on arm64 Ubuntu in favour of AzureLinux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We are testing Ubuntu on x64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that was intended to be temporary (#114268) and then switched back to Azure Linux 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, I'm not arguing for a specific configuration / test matrix - I just want to make sure the platform test coverage we do/don't have is an explicit decision now and for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That PR was a first toe-dip into adding AL3 support. As you saw, it failed. On the second attempt, we decided to take a different approach.
This is a constrained environment. We need decent coverage across OSes and to keep our costs low. The new (currently undocumented) approach you see showing up in my PRs is my best take on that. I normally write down plans ahead of time. I wasn't sure how to approach this space so let it take shape as I went (with help from Jan). I now have a pretty complete picture. I'll write it down shortly and then we can discuss it. I think it will end up making sense. If we want to adapt it (once people can comment on a bigger picture), that's A-OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BA is green. It would be great to get an approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW: Great questions / comments.