-
Notifications
You must be signed in to change notification settings - Fork 5k
Update Linux versions in CoreCLR pipeline #115757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @hoyosjs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Helix queue labels in the CoreCLR pipeline to newer OS and distro versions.
- Bumps Debian arm32 pools from 12 to 13
- Switches Ubuntu arm64 pools to Azure Linux 3.0 images
- Corrects casing and version consistency for Alpine musl x64 and macOS queues
/azp run runtime-libraries-coreclr outerloop-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
/ba-g "Tizen build failure unrelated" |
Looks like |
|
||
# Linux arm64 | ||
- ${{ if eq(parameters.platform, 'linux_arm64') }}: | ||
- ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
- (Ubuntu.2404.Arm64.Open)Ubuntu.2204.Armarch[email protected]/dotnet-buildtools/prereqs:ubuntu-24.04-helix-arm64v8 | ||
- (AzureLinux.3.0.ArmArch.Open)Ubuntu.2204.ArmArch[email protected]/dotnet-buildtools/prereqs:azurelinux-3.0-helix-arm64v8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an AZ3 VM running on Ubuntu, or vice versa?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct. It's testing AL3. The display text is for the container image not the VM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean we are intentionally dropping testing on arm64 Ubuntu in favour of AzureLinux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We are testing Ubuntu on x64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that was intended to be temporary (#114268) and then switched back to Azure Linux 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, I'm not arguing for a specific configuration / test matrix - I just want to make sure the platform test coverage we do/don't have is an explicit decision now and for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That PR was a first toe-dip into adding AL3 support. As you saw, it failed. On the second attempt, we decided to take a different approach.
This is a constrained environment. We need decent coverage across OSes and to keep our costs low. The new (currently undocumented) approach you see showing up in my PRs is my best take on that. I normally write down plans ahead of time. I wasn't sure how to approach this space so let it take shape as I went (with help from Jan). I now have a pretty complete picture. I'll write it down shortly and then we can discuss it. I think it will end up making sense. If we want to adapt it (once people can comment on a bigger picture), that's A-OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BA is green. It would be great to get an approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW: Great questions / comments.
No description provided.