Breakpoint from string flag parsing using token #9456
Conversation
For some reason when saving breakpoints, my GameSettings contains comma separated hex values. They Load just fine too. Maybe this is a quirk of |
There was a problem hiding this comment.
Tested and LGTM.
I suspect the comma is coming from your locale, that would explain why you have no issues when saving and loading.
This locale/comma issue should be addressed in its own PR as it needs to fix loading and saving BPs, on top of other saved config I guess. I'll probably address it by next week if I manage to find some time.
|
LGTM once changes are squashed into a single commit |
Since the string includes hex, the break_on_hit 'b' flag can be pulled from the address by accident istringstream for BreakPoint parsing
trevor403
force-pushed
the
breakpoint-loading
branch
from
bd8895b to
59058ba
Compare
|
@lioncash should be ready to merge once the checks run |
|
It seems as though checks are not running on my squashed commit |
|
The Pending pr-android status check seems to have run successfully on the Buildbot. Maybe it did not properly report the test status back to GitHub |
|
This bug was also fixed in #9334... |
|
#9334 will take longer to review so I think we should merge this first |
When searching the breakpoint string for
"b"for thebreak_on_hitflag you can get a false hit because the hex address may include the letterb. For example,80,0cb,46c nlwas incorrectly enabling break on hit.If you read the next token from the string stream, you will have the flags alone. You can then search these for each letter and you won't get a false hit.
This is quite a neat bug 😄