BreakpointWidget: Allow breakpoints to be toggled between enable/disable #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepalani
suggested changes
Feb 28, 2021
sepalani
reviewed
Mar 1, 2021
lioncash
reviewed
Mar 1, 2021
Added `ToggleBreakPoint` to both interface BreakPoints/MemChecks. this would allow us to toggle the state of the breakpoint. Also the TMemCheck::is_ranged is not longer serialized to string, since can be deduce by comparing the TMemCheck::start_address and TMemCheck::end_address
Added a context menu, for when a breakpoint is right-clicked Removed the `itemClicked` behavior, since it would clash with the context menu
|
Tested and appears to work. |
|
I don't know how strict we are with things, but there's a typo in the commit - Allow to disable/enable from the BreakpoinWidget |
|
@dolphin-emu-bot rebuild |
leoetlino
changed the title
leoetlino
approved these changes
Mar 4, 2021
|
Fixes comma separated hex values caused by locale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a way to disable/enable breakpoints at runtime, by adding a context menu that let you toggle between the two state.
Also, added a
Go toaction, that let you go to breakpoint address, this action is only added when the breakpoint is a instruction breakpoint.I removed the
itemClickedlistener since it was replaced with the context menuGo toaction.