Skip to content

Add a Service Account for issue #15#23

Closed
dhoover103 wants to merge 15 commits intodocling-project:mainfrom
dhoover103:main
Closed

Add a Service Account for issue #15#23
dhoover103 wants to merge 15 commits intodocling-project:mainfrom
dhoover103:main

Conversation

@dhoover103
Copy link
Contributor

WIP

SA still needs to be attached to the appropriate pod and all permissions ironed out.

@exe-prow-github-app exe-prow-github-app bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2025
@exe-prow-github-app exe-prow-github-app bot requested a review from dcurran90 April 7, 2025 17:29
@exe-prow-github-app
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhoover103

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@exe-prow-github-app exe-prow-github-app bot requested a review from mgoerens April 7, 2025 17:29
@exe-prow-github-app exe-prow-github-app bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
Copy link
Collaborator

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

Only change I see ATM is that the filename for the role has an extra 'k' in docling.

@acornett21
Copy link
Collaborator

@dhoover103 Thanks for the PR! Much appreciated. Did you need help figuring out what the docling-serv pod does to figure out the permissions? It's hard to read the initial comment if that's to yourself of to us. Either way happy to help, just let us know!

@dhoover103 dhoover103 changed the title WIP Service Account for issue #15 Add a Service Account for issue #15 Apr 21, 2025
@dhoover103 dhoover103 linked an issue Apr 21, 2025 that may be closed by this pull request
@dhoover103 dhoover103 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2025
@dhoover103 dhoover103 marked this pull request as ready for review April 21, 2025 19:28
@madorn madorn requested a review from bcrochet May 2, 2025 17:08
@madorn madorn requested review from madorn and removed request for acmenezes, dcurran90, jsm84 and mgoerens May 2, 2025 17:09
@acornett21
Copy link
Collaborator

/hold

@exe-prow-github-app exe-prow-github-app bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2025
@acornett21
Copy link
Collaborator

After discussion in slack, we've decided that this needs to live in code, and not in yaml files.

@dhoover103 dhoover103 closed this May 8, 2025
@dhoover103
Copy link
Contributor Author

closing in favor of a fresh PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a ServiceAccount for the docling-serve Pod

3 participants