Skip to content

Create a ServiceAccount for the docling-serve Pod #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acornett21 opened this issue Mar 25, 2025 · 6 comments
Closed

Create a ServiceAccount for the docling-serve Pod #15

acornett21 opened this issue Mar 25, 2025 · 6 comments
Assignees

Comments

@acornett21
Copy link
Collaborator

Currently, the deployment is not using a ServiceAccount, so the default SA is getting assigned. This is not ideal, so we should create an SA with the proper permissions to run this workload.

Two options:

  • Create an additional sa in the bundle
  • Create a new reconciler to create the SA and permissions before the deployment reconciler is called.
@dhoover103 dhoover103 self-assigned this Mar 27, 2025
@dhoover103
Copy link
Contributor

Working on building out Option 1 - creating a new SA

@dhoover103
Copy link
Contributor

Draft PR #23 created for addressing this issue

@dhoover103
Copy link
Contributor

Sorry, this has needed an update and I haven't dropped one in a while.

I'm working on getting the SA into the reconciler, but hitting errors creating the deployment now. I'm continuing to troubleshoot, and hope to have a good update to the PR soon.

@dhoover103
Copy link
Contributor

I was able to find what I was missing in the reconciler, but then I went and made some small changes to clean up the code, and now I'm suddenly getting an error. I'll look into it Monday and it should be pretty small to fix.

@dhoover103 dhoover103 linked a pull request Apr 21, 2025 that will close this issue
@dhoover103
Copy link
Contributor

Almost have the rework done - I'll open a new PR tomorrow with the changes. At the moment, I've got a couple syntax errors I'm still trying to iron out, so I'll likely open a draft PR to get some help fixing it.

@acornett21
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants