-
Notifications
You must be signed in to change notification settings - Fork 7
Refactor for Deno compatibility and DevContainer setup #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devinpearson
wants to merge
6
commits into
main
Choose a base branch
from
devcontainer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
80fa5ff
Refactoring to allow for the conversion to deno
devinpearson 8048286
devcontainer testing
devinpearson f176b26
testing workspace
devinpearson c842a60
Added devcontainer details to readme
devinpearson e953653
Added additional details to 3 legged flow
devinpearson eb0157e
Add approve and decline routes for OAuth consent
devinpearson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| .dockerignore | ||
| .env | ||
| .git | ||
| .gitignore | ||
| .vs | ||
| .vscode | ||
| docker-compose.yml | ||
| docker-compose.*.yml | ||
| node_modules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| FROM node:20.12.2 | ||
| #FROM nikolaik/python-nodejs:latest | ||
| # Last version check on 10 Apr 2024. | ||
| # Check for new versions at https://nodejs.org/en/ or at https://hub.docker.com/_/node | ||
| # Note that if you want to use this container for a Create React Application (CRA) | ||
| # you may need to use a different version. Consult React documentation. | ||
| # [Manfred] | ||
|
|
||
|
|
||
| ################################################################################ | ||
| # Upgrade NPM | ||
| # node may come with an older version of npm. Ensure we have a specific npm. | ||
| RUN npm install -g [email protected] | ||
| # Last version check on 10 Apr 2024. | ||
| # Newer versions might be available at https://www.npmjs.com/search?q=npm | ||
| # [Manfred] | ||
|
|
||
|
|
||
| ################################################################################ | ||
| # Install prerequisites | ||
| RUN apt-get update | ||
| RUN apt-get install -y \ | ||
| lsb-release \ | ||
| curl | ||
|
|
||
|
|
||
| ################################################################################ | ||
| # Install TypeScript | ||
| RUN npm install -g [email protected] | ||
| # Last version check on 10 Apr 2024. | ||
| # Newer versions might be available at https://www.npmjs.com/search?q=typescript | ||
| # [Manfred] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // See https://aka.ms/vscode-remote/devcontainer.json for format details. | ||
| { | ||
| "name": "TypeScript example", | ||
| "dockerComposeFile": [ | ||
| "docker-compose.yml" | ||
| ], | ||
| // The name of the following service has to match one of the services in docker-compose.yml | ||
| "service": "typescript-dev", | ||
| "workspaceFolder": "/work", | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "dbaeumer.vscode-eslint", | ||
| "donjayamanne.githistory", | ||
| "editorconfig.editorconfig", | ||
| "firsttris.vscode-jest-runner", | ||
| "github.copilot@prerelease", | ||
| "github.copilot-chat@prerelease", | ||
| "github.copilot-labs@prerelease", | ||
| "mhutchie.git-graph", | ||
| "ms-vsliveshare.vsliveshare", | ||
| "mutantdino.resourcemonitor", | ||
| "qcz.restart-ts-server-button", | ||
| "rtbenfield.vscode-jest-test-adapter", | ||
| "usernamehw.errorlens" | ||
| ] | ||
| } | ||
| }, | ||
| "shutdownAction": "stopCompose", | ||
| "remoteUser": "node" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Documentation of compose spec can be found at https://github.com/compose-spec/compose-spec | ||
| # [Manfred, 21apr2023] | ||
|
|
||
| version: '3.7' | ||
|
|
||
| # According to the compose spec we can specify the compose project name here. However, VS Code does | ||
| # not honor this as of 21 Apr 2023. Therefore there is a .env file at the root of this git repository | ||
| # in which the environment variable COMPOSE_PROJECT_NAME is defined as 'rimutec'. Once VS Code supports | ||
| # the top-level element 'name', the following can be used instead. | ||
| name: 'developer' | ||
| # [Manfred, 21apr2023] | ||
|
|
||
| services: | ||
| # change the service name, the container name and the hostname for each dev container that connects | ||
| # to the same virtual network. [Manfred, 29jul2022] | ||
| typescript-dev: | ||
| image: typescript-dev:0.1 | ||
| build: . | ||
| container_name: typescript-dev | ||
| hostname: typescript-dev.local | ||
| working_dir: /work | ||
| ports: | ||
| # Change the port number in case you have more than one dev container based on this | ||
| # template. For example, you could use something like: | ||
| # - "3100:3000" | ||
| # [Manfred, 29jul2022] | ||
| - "3000:3000" # <<<<<< if preferred, explicit forward the port used by express | ||
| # Using double quotes for port mapping to avoid YAML reading it as a number with a different base | ||
| # e.g. "3333:22" would result in port numbers greater than 130000 which are clearly invalid. | ||
| # Without double quotes YAML interprets it as a number based on 22. [Manfred, 24aug2022] | ||
| volumes: | ||
| - ..:/work | ||
| command: bash -c "/work/.devcontainer/init.sh && sleep infinity" | ||
| networks: | ||
| developer: | ||
|
|
||
| # If you list further services (ie containers) here, place them in the same virtual network if | ||
| # you want them being visible to each other. [Manfred, 10sep2022] | ||
|
|
||
| networks: | ||
| developer: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # #!/bin/sh | ||
|
|
||
| echo Running script ./.devcontainer/init.sh | ||
|
|
||
| ################################################################################ | ||
| # Set get pull mode to rebase. Do the same for branches that may exist. However | ||
| # this is a repo designed for trunk-based development, so there shouldn't be any | ||
| # branches other than 'main' [Manfred, 22aug2022] | ||
| # For more details, see https://stackoverflow.com/a/13974638/411428 | ||
| runuser -l node -c 'cd /work && git config pull.rebase true' | ||
| runuser -l node -c 'cd /work && git config branch.autosetuprebase always' | ||
| # option -l specifies the user on whose behalf the commmand is executed. Note that | ||
| # this script runs as root. [Manfred, 12 Feb 2023] | ||
|
|
||
| echo Script ./.devcontainer/init.sh finished | ||
This file was deleted.
Oops, something went wrong.
48 changes: 0 additions & 48 deletions
48
.../workflows/programmablebanking-AutoDeployTrigger-b8b99f1a-47cf-45a3-8581-520a0a87e69d.yml
This file was deleted.
Oops, something went wrong.
48 changes: 0 additions & 48 deletions
48
...lows/programmablebanking-team1-AutoDeployTrigger-23e2c662-2901-496b-8e70-b70cadcb7773.yml
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the Shebang Line
The shebang line on line 1 contains an extra
#character, which prevents the interpreter directive from being recognized. Change it to#!/bin/shso that the script runs with the correct shell.📝 Committable suggestion
🧰 Tools
🪛 Shellcheck (0.10.0)
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)