feat: adding delete_by_filter and update_by_filter to PineconeDocumentStore
#2655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:pinecone
type:documentation
davidsbatista
changed the title
delete_by_filter and update_by_filter` to PineconeDocumentStore
davidsbatista
changed the title
delete_by_filter and update_by_filter` to PineconeDocumentStoredelete_by_filter and update_by_filter to PineconeDocumentStore`
davidsbatista
changed the title
delete_by_filter and update_by_filter to PineconeDocumentStore`delete_by_filter and update_by_filter to PineconeDocumentStore
vblagoje
approved these changes
Jan 8, 2026
Member
vblagoje
left a comment
vblagoje
left a comment
There was a problem hiding this comment.
What's this _log_top_k_limit_warning - seems unrelated?
| index=self.index_name, | ||
| ) | ||
|
|
||
| self._log_top_k_limit_warning(deleted_count, "deleted") |
Contributor
Author
There was a problem hiding this comment.
I will remove this, did as well for other doc stores already.
davidsbatista
deleted the
feat/add-update-delete-by-filter-to-PineConeDocumentStore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
update_by_filter()anddelete_by_filter()operations toPineConeDocumentStore#2333Proposed Changes:
delete_by_filter()- Delete documents matching filter criteriaupdate_by_filter()- Update metadata of documents matching filter criteriaHow did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.