Skip to content

Fix terminal Ctrl+A/D tab cycling #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parsakhaz merged 1 commit into from
May 5, 2026
Merged

Fix terminal Ctrl+A/D tab cycling #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion frontend/src/stores/hotkeyStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ function normalizeHotkeyString(keys: string): string {
let listenerAttached = false;
let lookupIndex: Map<string, string> = new Map(); // normalized keys → hotkey id

function isXtermHelperTarget(target: HTMLElement): boolean {
return target.classList.contains('xterm-helper-textarea') || target.closest('.xterm') !== null;
}

function handleKeyDown(e: KeyboardEvent) {
const target = e.target as HTMLElement;
const isInput =
Expand All @@ -139,7 +143,7 @@ function handleKeyDown(e: KeyboardEvent) {
// Let native text editing win for shortcuts users expect in focused inputs.
// In particular, tab cycling uses mod+a/mod+d, but inputs need mod+a
// for select-all and mod+d for normal browser/text-field behavior.
if (isInput && (pressed === 'mod+a' || pressed === 'mod+d')) return;
if (isInput && !isXtermHelperTarget(target) && (pressed === 'mod+a' || pressed === 'mod+d')) return;

// Skip if typing in input and shortcut doesn't use mod key
if (isInput && !pressed.includes('mod')) return;
Expand Down
Loading