Skip to content

Fix terminal Ctrl+A/D tab cycling#167

Merged
parsakhaz merged 1 commit intomainfrom
fix-ctrl-a-ctrl-d-behavior
May 5, 2026
Merged

Fix terminal Ctrl+A/D tab cycling#167
parsakhaz merged 1 commit intomainfrom
fix-ctrl-a-ctrl-d-behavior

Conversation

@parsakhaz
Copy link
Copy Markdown
Member

Summary

  • Preserve native Ctrl+A/Ctrl+D behavior for real focused text inputs.
  • Exempt xterm.js helper textarea from that input guard so terminal focus can still use Pane tab cycling.

Visual Overview

Before:

flowchart LR
  Key[Ctrl+A / Ctrl+D in terminal] --> Xterm[xterm helper textarea]
  Xterm --> InputGuard[Hotkey input guard]
  InputGuard --> Blocked[Pane tab cycling blocked]
Loading

After:

flowchart LR
  Key[Ctrl+A / Ctrl+D in terminal] --> Xterm[xterm helper textarea]
  Xterm --> Exempt[xterm target exemption]
  Exempt --> Hotkey[Pane hotkey store]
  Hotkey --> Switch[Switch panel tabs]
Loading

Testing

  • pnpm run --filter frontend typecheck
  • pnpm run --filter frontend lint
  • git diff --check
  • Pre-commit hook: full workspace typecheck and lint passed

Note: local commands report the existing Node engine warning because this shell uses Node v20.19.3 while the repo requires >=22.14.0.

@parsakhaz parsakhaz merged commit f0c19ad into main May 5, 2026
1 check passed
@parsakhaz parsakhaz deleted the fix-ctrl-a-ctrl-d-behavior branch May 5, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant