Skip to content

chore: make calc_withdraw_one_coin simulation consistent with _calc_withdraw_one_coin #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

chore: make calc_withdraw_one_coin simulation consistent with _calc_withdraw_one_coin #86

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c45b360
Make calc_withdraw_one_coin consistent with _calc_withdraw_one_coin
michaelhly Nov 21, 2020
d110681
Fix
michaelhly Nov 21, 2020
36191e2
Add test
michaelhly Nov 21, 2020
a5d0083
Fix
michaelhly Nov 21, 2020
a3d1d56
-1 to account for rounding errors
michaelhly Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/pools/common/unitary/test_remove_liquidity_one_coin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import brownie
import pytest
from simulation import Curve

pytestmark = [
pytest.mark.skip_pool("busd", "compound", "pax", "susd", "usdt", "y"),
Expand Down Expand Up @@ -81,3 +82,13 @@ def test_below_zero(alice, swap):
def test_above_n_coins(alice, swap, wrapped_coins, n_coins):
with brownie.reverts():
swap.remove_liquidity_one_coin(1, n_coins, 0, {'from': alice})

@pytest.mark.itercoins("idx")
def test_against_simulation(alice, swap, n_coins, pool_token, idx):
amount = pool_token.balanceOf(alice)

balances = [swap.balances(i) for i in range(n_coins)]
curve_model = Curve(swap.A(), balances, n_coins, tokens=pool_token.totalSupply())
expected, _ = curve_model.calc_withdraw_one_coin(amount, idx)

assert swap.swap.calc_withdraw_one_coin(amount, idx) == expected
Copy link

@halito22 halito22 Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you