chore: make calc_withdraw_one_coin simulation consistent with _calc_withdraw_one_coin #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhly
changed the title
michaelhly
force-pushed
the
master
branch
6 times, most recently
from
0b06d9e to
d64a10d
Compare
michaelhly
changed the title
Contributor
|
Ohh very nice |
Author
|
Hmm...not sure what to do about these timeouts. @iamdefinitelyahuman @michwill any tips? |
michwill
approved these changes
Nov 25, 2020
Contributor
michwill
left a comment
michwill
left a comment
There was a problem hiding this comment.
Looks good to merge! Anyone has any more comments?
Contributor
|
Yeah, idk why timeouts |
Member
|
Seems the new test in |
Author
I will give that a try and report back. |
alski2020
approved these changes
Sep 19, 2021
halito22
approved these changes
Nov 17, 2021
| def calc_withdraw_one_coin(self, token_amount, i): | ||
| xp = self.xp() | ||
| xp_reduced = xp | ||
| xp_reduced = list(xp) |
| dy = xp_reduced[i] - self.y_D(i, D1) | ||
| self.x = [x // (p // 10 ** 18) for x, p in zip(xp, self.p)] | ||
| dy_0 = (xp[i] - new_y) | ||
| dy_0 = xp[i] - new_y |
halito22
approved these changes
Nov 17, 2021
| curve_model = Curve(swap.A(), balances, n_coins, tokens=pool_token.totalSupply()) | ||
| expected, _ = curve_model.calc_withdraw_one_coin(amount, idx) | ||
|
|
||
| assert swap.swap.calc_withdraw_one_coin(amount, idx) == expected |
halito22
approved these changes
Nov 17, 2021
| curve_model = Curve(swap.A(), balances, n_coins, tokens=pool_token.totalSupply()) | ||
| expected, _ = curve_model.calc_withdraw_one_coin(amount, idx) | ||
|
|
||
| assert swap.calc_withdraw_one_coin(amount, idx) == expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Change
calc_withdraw_one_coinin simulation.py to represent the source of truth instead of approximation.How I did it
Made
calc_withdraw_one_coinin simulation.py to exhibit the same behavior as_calc_withdraw_one_coinHow to verify it
Added test