Skip to content

Fix OSS CI validation baseline - #934

Open
mkrtc wants to merge 1 commit into
craft-ai-agents:mainfrom
mkrtc:fix/oss-ci-validation-baseline
Open

Fix OSS CI validation baseline#934
mkrtc wants to merge 1 commit into
craft-ai-agents:mainfrom
mkrtc:fix/oss-ci-validation-baseline

Conversation

@mkrtc

@mkrtc mkrtc commented Jun 30, 2026

Copy link
Copy Markdown

Summary

  • add the missing root tsconfig.base.json used by package TypeScript configs
  • add the missing scripts/check-i18n-coverage.ts script already referenced by validate:ci
  • refresh bun.lock workspace metadata so bun install --frozen-lockfile succeeds in CI

Problem

A fresh OSS checkout could not complete the configured validation workflow:

  • bun install --frozen-lockfile reported that the lockfile needed updates
  • package typechecks extended ../../tsconfig.base.json, but that file was not present at the repository root
  • bun run validate:ci referenced scripts/check-i18n-coverage.ts, but the script was missing

This meant the public validation workflow could fail before reaching the actual test suite.

Solution

This PR restores the baseline files expected by the existing scripts/configs:

  • adds a shared TypeScript base config with the repository-wide compiler defaults
  • adds a CI-safe i18n coverage checker for literal translation keys in t(...), i18n.t(...), and Trans i18nKey callsites
  • updates the lockfile metadata to match the current workspace layout/version so frozen installs are reproducible

Related PRs

Related to #662 and #906. This PR keeps the scope limited to the validation baseline and includes the current bun.lock refresh required for the configured bun install --frozen-lockfile CI step.

Validation

  • bun install --frozen-lockfile
  • bun run validate:ci

Add the root TypeScript baseline and i18n coverage checker needed by validate:ci, and refresh bun.lock against current upstream main so frozen installs succeed.

Co-Authored-By: Craft Agent <agents-noreply@craft.do>
@mkrtc
mkrtc force-pushed the fix/oss-ci-validation-baseline branch from cfb3234 to 96d4320 Compare July 2, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant