feat: Change highlighted item color ✨ #2867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonUnchanged files (3)
No change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
rezk2ll
approved these changes
Oct 7, 2025
zatteo
approved these changes
Oct 7, 2025
|
🎉 This PR is included in version 130.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@lethemanh We discuss it here #2861, then take (wrong, but that's ok :) ) decision... Can you explain why this PR please and give everyone some context? |
In dark mode, the highlight color does not match the selected color so I have to make the change. You can see here cozy/cozy-drive#3508 (comment) |
|
Ok I'm not surprised as I said here #2861 (review) . Don't hesitate to explain the "why" in the PR description :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
In dark mode, the highlight color does not match the selected color so this PR will make the change of highlight color.
Relate to:
cozy/cozy-drive#3508