feat(TableRow, VirtualizedTable): add isNewItem prop highlight new items #2861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coussecousse
requested review from
JF-Cozy,
Ldoppea and
zatteo
as code owners
BundleMonUnchanged files (3)
No change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
JF-Cozy
reviewed
Sep 24, 2025
Coussecousse
force-pushed
the
ean_newItems
branch
2 times, most recently
from
879590d to
810093c
Compare
rezk2ll
approved these changes
Sep 25, 2025
…ms and highlight them - IsNewItem check if the item is the same as in the list.
lethemanh
force-pushed
the
ean_newItems
branch
from
810093c to
0250f69
Compare
|
🎉 This PR is included in version 130.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
JF-Cozy
reviewed
Oct 7, 2025
| className={dragCollect.isDragging ? 'virtualized u-o-50' : 'virtualized'} | ||
| className={cx( | ||
| dragCollect.isDragging ? 'virtualized u-o-50' : 'virtualized', | ||
| isNew ? 'u-bg-primaryColorLight' : '' |
There was a problem hiding this comment.
be careful we don't use u-classes to change color anymore, don't know if they are still relevant. For now I recommand to avoid this while someone didn't take a deep look on it.. For example it's not compliant with dark mode, see #2867 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bob ask me to work on a functionnality that 'highlight' in blue the new items.
It used the same blue as selected items.
The isNewItem prop can be null without causing an issue.
Example :
Code in tdrive cozy/cozy-drive#3501 .