Skip to content

Upgrade cozy-client and deal with optional chaining problem with @fastify/deepmerge package #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

Upgrade cozy-client and deal with optional chaining problem with @fastify/deepmerge package #2837

merged 1 commit into from
Sep 2, 2025

Conversation

@rezk2ll
Copy link
Contributor

@rezk2ll rezk2ll commented Aug 27, 2025

this change was missing, refer: #2828 (comment)

JF-Cozy
JF-Cozy reviewed Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@JF-Cozy JF-Cozy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to upgrade peerDependencies as well (so it's a breaking change, you have to add this keyword somewhere, see https://github.com/cozy/cozy-guidelines?tab=readme-ov-file#breaking-change), and cozy-stack-client (when you upgrade cozy-client, you have to upgrade cozy-stack-client also)

@rezk2ll @JF-Cozy
feat: upgrade cozy-client
ef7c1a7 
BREAKING CHANGE: You must have `cozy-client >=60.5.0`
@JF-Cozy JF-Cozy changed the title chore: upgrade cozy-client to v60.3.0 🔖 Upgrade cozy-client and deal with optional chaining problem with fastify deepmerge package Sep 2, 2025
@JF-Cozy JF-Cozy changed the title Upgrade cozy-client and deal with optional chaining problem with fastify deepmerge package Upgrade cozy-client and deal with optional chaining problem with @fastify/deepmerge package Sep 2, 2025
@bundlemon
Copy link

bundlemon bot commented Sep 2, 2025

BundleMon

Unchanged files (3)
Status Path Size Limits
✅ dist/cozy-ui.min.css
 20.02KB -
✅ transpiled/react/stylesheet.css
 17.71KB -
✅ dist/cozy-ui.utils.min.css
 10.97KB -

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ transpiled/react/**
 1009.38KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@JF-Cozy
Copy link
Collaborator

JF-Cozy commented Sep 2, 2025 •
edited
Loading

Because of webkpack v4 doesn't handle optional chaining by itself, we have to create a patch to rewrite it with standard condition. We tried with plugins but with no success.

We have to replace webpack by rsbuild for exemple, it's a work in progress...

@JF-Cozy JF-Cozy merged commit 6dc714d into master Sep 2, 2025
12 checks passed
@JF-Cozy JF-Cozy deleted the bump-cozy-client branch September 2, 2025 09:09
@cozy-bot
Copy link

cozy-bot commented Sep 2, 2025

🎉 This PR is included in version 128.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lethemanh lethemanh mentioned this pull request Sep 3, 2025
Merged
This was referenced Sep 3, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF-Cozy JF-Cozy JF-Cozy left review comments

@Ldoppea Ldoppea Awaiting requested review from Ldoppea

@zatteo zatteo Awaiting requested review from zatteo zatteo is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rezk2ll @JF-Cozy @cozy-bot