fix(packages): Don't apply patch-package if no package to patch #2843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonUnchanged files (3)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
zatteo
approved these changes
Sep 3, 2025
|
🎉 This PR is included in version 128.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2837
revert #2842
I hope this is the final solution :) The problem is that we need to apply the patch in cozy-ui to build the documentation with webpack 4, but we don't need the patch in an app because we use rsbuild (which doesn't cause any problems).
However, when installing packages in the app, cozy-ui dependencies are installed in the app's
node_modulesand not innode_modules/cozy-ui/node_modules. Cozy-ui's postinstall then tries to apply a patch to a library it can't find.