Skip to content

chore: remove stale TODO and dead code in upgrade tests #25446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: remove stale TODO and dead code in upgrade tests #25446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions tools/cosmovisor/upgrade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ import (
"fmt"
"os"
"path/filepath"
"slices"
"strings"
"slices"
"testing"

"github.com/otiai10/copy"
Expand Down Expand Up @@ -116,7 +115,6 @@ func (s *upgradeTestSuite) assertCurrentLink(cfg *cosmovisor.Config, target stri
s.Require().Equal(target, dest)
}

// TODO: test with download (and test all download functions)
func (s *upgradeTestSuite) TestUpgradeBinaryNoDownloadUrl() {
cfg := prepareConfig(
s.T(),
Expand Down Expand Up @@ -175,13 +173,11 @@ func (s *upgradeTestSuite) TestUpgradeBinary() {
cases := map[string]struct {
url string
canDownload bool
validBinary bool
}{
"get raw binary with checksum": {
// sha256sum ./testdata/repo/raw_binary/autod
url: workDir + "/testdata/repo/raw_binary/autod?checksum=sha256:e6bc7851600a2a9917f7bf88eb7bdee1ec162c671101485690b4deb089077b0d",
canDownload: true,
validBinary: true,
},
"get raw binary with invalid checksum": {
url: workDir + "/testdata/repo/raw_binary/autod?checksum=sha256:73e2bd6cbb99261733caf137015d5cc58e3f96248d8b01da68be8564989dd906",
Expand All @@ -190,7 +186,6 @@ func (s *upgradeTestSuite) TestUpgradeBinary() {
"get zipped directory with valid checksum": {
url: workDir + "/testdata/repo/chain3-zip_dir/autod.zip?checksum=sha256:8951f52a0aea8617de0ae459a20daf704c29d259c425e60d520e363df0f166b4",
canDownload: true,
validBinary: true,
},
"get zipped directory with invalid checksum": {
url: workDir + "/testdata/repo/chain3-zip_dir/autod.zip?checksum=sha256:73e2bd6cbb99261733caf137015d5cc58e3f96248d8b01da68be8564989dd906",
Expand All @@ -203,7 +198,6 @@ func (s *upgradeTestSuite) TestUpgradeBinary() {
"valid remote": {
url: "https://github.com/cosmos/cosmos-sdk/raw/main/tools/cosmovisor/testdata/repo/chain3-zip_dir/autod.zip?checksum=sha256:8951f52a0aea8617de0ae459a20daf704c29d259c425e60d520e363df0f166b4",
canDownload: true,
validBinary: true,
},
}

Expand All @@ -219,11 +213,7 @@ func (s *upgradeTestSuite) TestUpgradeBinary() {
},
)

url := tc.url
if strings.HasPrefix(url, "./") {
url, err = filepath.Abs(url)
s.Require().NoError(err)
}
url := tc.url

plan := upgradetypes.Plan{
Name: "amazonas",
Expand Down