Skip to content

chore: remove stale TODO and dead code in upgrade tests #25446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: remove stale TODO and dead code in upgrade tests #25446

wants to merge 1 commit into from

Conversation

phrwlk
Copy link

@phrwlk phrwlk commented Oct 14, 2025

Description

  • Removed outdated TODO about download tests; they already exist in this file and related tests.
  • Deleted unused validBinary field and its initializations in TestUpgradeBinary table.
  • Removed unreachable "./" URL normalization branch that was never exercised.

@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Oct 14, 2025
@aljo242 aljo242 closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

C:Cosmovisor Issues and PR related to Cosmovisor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phrwlk @aljo242