fix(segmentation): Set the representation visible when setting segment visible #2525
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After setting all segments of a segmentation to be not visible, individual segments cannot have their visibility toggled.
This can be seen in the Spline Segmentation ROI Tool example as demonstrated in the video below.
ScreenHunter.Dec.18.09.55.mp4
Changes & Results
The problem exists because when a segmentation in its entirety is made not visible, the segmentation's visible flag is set to false. Thus when an individual segment is toggled visible, its segmentation visible flag should also get flipped.
Here is the result...
ScreenHunter.Dec.18.10.11.mp4
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment
System:
OS: Windows 11 10.0.26200
CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
Memory: 8.54 GB / 31.68 GB
Binaries:
Node: 23.9.0 - C:\Users\joebo\AppData\Local\fnm_multishells\34284_1766069731735\node.EXE
Yarn: 1.22.22 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 10.9.2 - C:\Users\joebo\AppData\Local\fnm_multishells\34284_1766069731735\npm.CMD
bun: 1.2.23 - C:\Users\joebo.bun\bin\bun.EXE
Browsers:
Chrome: 143.0.7499.110