Skip to content

Conversation

@jbocce
Copy link
Collaborator

@jbocce jbocce commented Dec 18, 2025

Context

After setting all segments of a segmentation to be not visible, individual segments cannot have their visibility toggled.

This can be seen in the Spline Segmentation ROI Tool example as demonstrated in the video below.

ScreenHunter.Dec.18.09.55.mp4

Changes & Results

The problem exists because when a segmentation in its entirety is made not visible, the segmentation's visible flag is set to false. Thus when an individual segment is toggled visible, its segmentation visible flag should also get flipped.

Here is the result...

ScreenHunter.Dec.18.10.11.mp4

Testing

  1. Run the Spline Segmentation ROI Tool example.
  2. Add a spline to segment 1 and a spline to segment 2.
  3. Toggle all the segments to be not visible.
  4. Toggle one of the individual segments visible.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

System:
OS: Windows 11 10.0.26200
CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
Memory: 8.54 GB / 31.68 GB
Binaries:
Node: 23.9.0 - C:\Users\joebo\AppData\Local\fnm_multishells\34284_1766069731735\node.EXE
Yarn: 1.22.22 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 10.9.2 - C:\Users\joebo\AppData\Local\fnm_multishells\34284_1766069731735\npm.CMD
bun: 1.2.23 - C:\Users\joebo.bun\bin\bun.EXE
Browsers:
Chrome: 143.0.7499.110

@jbocce jbocce requested a review from sedghi December 18, 2025 15:13
@jbocce jbocce merged commit ea2e968 into cornerstonejs:main Dec 18, 2025
10 checks passed
@jbocce jbocce deleted the fix/OHIF-2371-seg-visibility branch January 6, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants