Skip to content

Conversation

@jbocce
Copy link
Collaborator

@jbocce jbocce commented Dec 18, 2025

Context

Fixes #5647

Changes & Results

Pull in CS3D 4.14.6. See CS3D PR: cornerstonejs/cornerstone3D#2525

Testing

See #5647. Also see cornerstonejs/cornerstone3D#2525

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

System:
OS: Windows 11 10.0.26200
CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
Memory: 6.73 GB / 31.68 GB
Binaries:
Node: 20.9.0 - C:\Users\joebo\AppData\Local\fnm_multishells\34284_1766069731735\node.EXE
Yarn: 1.22.22 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 10.1.0 - C:\Users\joebo\AppData\Local\fnm_multishells\34284_1766069731735\npm.CMD
bun: 1.2.23 - C:\Users\joebo.bun\bin\bun.EXE
Browsers:
Chrome: 143.0.7499.110

@netlify
Copy link

netlify bot commented Dec 18, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 57e5a83
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/69444237d2b900000874f191
😎 Deploy Preview https://deploy-preview-5664--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aimee-ferreira
Copy link
Collaborator

Hi @jbocce,

I found an issue - jump to segmentation is broken on manually added contour segments:
Steps to reproduce

  1. Display any study e.g. https://deploy-preview-5664--ohif-dev.netlify.app/segmentation?StudyInstanceUIDs=1.3.6.1.4.1.25403.345050719074.3824.20170125113417.1
  2. Add multiple contour segments
  3. Click to jump to segment
    Result: Nothing happens
    Note: label map jump to segmentation is working correctly
Screen.Recording.2025-12-18.124151.mp4

@jbocce
Copy link
Collaborator Author

jbocce commented Dec 18, 2025

Hi @jbocce,

I found an issue - jump to segmentation is broken on manually added contour segments: Steps to reproduce

  1. Display any study e.g. https://deploy-preview-5664--ohif-dev.netlify.app/segmentation?StudyInstanceUIDs=1.3.6.1.4.1.25403.345050719074.3824.20170125113417.1
  2. Add multiple contour segments
  3. Click to jump to segment
    Result: Nothing happens
    Note: label map jump to segmentation is working correctly

Screen.Recording.2025-12-18.124151.mp4

Good catch @aimee-ferreira . As we discussed please add these details to #5640 as well. Thanks.

@jbocce jbocce merged commit 3440f66 into OHIF:master Dec 18, 2025
6 of 7 checks passed
@jbocce jbocce deleted the fix/OHIF-2371-seg-visibility branch December 18, 2025 18:35
@aimee-ferreira
Copy link
Collaborator

aimee-ferreira commented Dec 18, 2025

I ended up creating a new defect for that issue, as it's a little bit different. All other tests passed.
#5665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] After hide all segments, individual segmentations cannot be made visible

3 participants