Support Ruby 3.4 and ActiveRecord 7.2 #21
Conversation
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- gemfiles/ar70.gemfile: Language not supported
- gemfiles/ar71.gemfile: Language not supported
- gemfiles/ar72.gemfile: Language not supported
Comments suppressed due to low confidence (1)
armg.gemspec:29
- Consider verifying if 'base64' is necessary as a development dependency, as it is part of Ruby's standard library.
spec.add_development_dependency 'base64'
|
|
||
| - Ruby 3.1 to 3.4 | ||
| - ActiveRecord 7.0 to 7.2 | ||
| - MySQL 5.6 to 8.0 |
There was a problem hiding this comment.
How about dropping support for MySQL 5.x here or in another pull request?
There was a problem hiding this comment.
Official support for MySQL 5.x has already ended:
https://endoflife.date/mysql
That said, some managed services like AWS still offer extended support:
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/MySQL.Concepts.VersionMgmt.html
Maybe it would make sense to handle both the end of support for 5.x and the addition of MySQL 8.4 (LTS) in a separate PR.
There was a problem hiding this comment.
I'll open a separate issue for that.
|
|
||
| - Ruby 3.1 to 3.4 | ||
| - ActiveRecord 7.0 to 7.2 | ||
| - MySQL 5.6 to 8.0 |
There was a problem hiding this comment.
Official support for MySQL 5.x has already ended:
https://endoflife.date/mysql
That said, some managed services like AWS still offer extended support:
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/MySQL.Concepts.VersionMgmt.html
Maybe it would make sense to handle both the end of support for 5.x and the addition of MySQL 8.4 (LTS) in a separate PR.
This PR updates the test matrix to use Ruby versions 3.1–3.4 (previously 2.7–3.1) and Rails versions 7.0–7.2 (previously 6.0–7.0).
I selected the lower bounds because they represent the most recent end-of-life versions, ensuring support for all officially maintained releases plus one additional legacy version.
These changes also serve as a preparatory step for Rails 8.0 support (#20).
Upgrading to Ruby 3.4 requires adding new development dependencies for bundled gems, and upgrading to Rails 7.2 involves modifying a test helper.
In both cases, production code remains unchanged.