Skip to content

Support ActiveRecord 8.0 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Support ActiveRecord 8.0 #22

merged 2 commits into from
Apr 7, 2025

Conversation

akouryy
Copy link
Member

@akouryy akouryy commented Apr 7, 2025

Fixes #20.

This pull request adds support for ActiveRecord 8.0.
I have run the examples in the README against rails new locally to confirm that they work as expected.

In this PR, I chose to remove the upper version limit on the dependency, primarily to reduce the maintenance burden.

@akouryy akouryy requested review from a team and Copilot April 7, 2025 06:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • gemfiles/ar80.gemfile: Language not supported
Comments suppressed due to low confidence (2)

armg.gemspec:26

  • There is a discrepancy between the gemspec dependency (>= 7) and the changelog which mentions support for ActiveRecord 7.1 and 7.2. Please verify whether ActiveRecord 7.0 is fully supported or update the documentation and changelog to reflect the correct minimal supported version.
spec.add_dependency 'activerecord', '>= 7'

.github/workflows/test.yml:30

  • The inline comment in the exclusion list may be interpreted as an array element. Consider removing or relocating the comment to ensure the exclusion block functions as intended.
- # Ruby 3.1 is not supported by ActiveRecord 8.0

@akouryy akouryy marked this pull request as draft April 7, 2025 06:57
@akouryy
Copy link
Member Author

akouryy commented Apr 7, 2025

I just discovered that the files under gemfiles/ are automatically generated by Appraisal. So, I've added a commit to update the Appraisals file to reflect the changes in this PR and #21.

@akouryy akouryy marked this pull request as ready for review April 7, 2025 07:02
@akouryy akouryy requested a review from Copilot April 7, 2025 08:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • gemfiles/ar70.gemfile: Language not supported
  • gemfiles/ar80.gemfile: Language not supported

@akouryy akouryy merged commit ff74bee into master Apr 7, 2025
150 checks passed
@akouryy akouryy deleted the support-rails-8 branch April 7, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not update to Rails 8 because it's not compatible
2 participants