Pr 6822: Reproduced and fixed #6889
Open
+535
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented debounced search to filter docs. Added sorting options by status, name, or URL. Introduced grouping by domain or category with collapsible sections. Improved user experience by providing a clear, flexible interface for managing large documentation sets.
Provides a reusable debounce function to delay execution after user actions. Useful for search implementations and event handler optimizations.
Tests cover search functionality, sorting options, grouping logic, collapsible groups, empty states, and debounce behavior. Ensures stable and reliable implementation of DocsSection improvements.
- Remove duplicate Select imports (6 duplicates removed) - Replace undefined complex Select components with standard HTML select - Use existing Select wrapper component for consistency - Apply prettier formatting
- Update Select mock to match actual implementation (simple select) - Fix test assertions to use 'select' instead of 'select-trigger' - Remove unused debounce.ts file (component uses built-in useEffect)
dosubot
bot
added
the
size:XL
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Replace unsafe substring checks with proper URL parsing - Prevent malicious URLs like 'evil.com/github.com' from being categorized as GitHub - Check hostname explicitly for domain validation - Check pathname for documentation patterns instead of full URL string
|
The CI errors are here likely related to some recent changes on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed incorrect Select component usage in DocsSection.tsx that was causing lint/build errors. The component was using a complex Select/Option structure that didn't match the actual Select wrapper implementation, which simply wraps a standard HTML select element.
Checklist
Screen recording or screenshot
N/A - Simple component fix
Tests
Build and lint checks pass. Existing component tests may fail due to unrelated Redux state issues in Auth.tsx.
Summary by cubic
Fixed incorrect Select component usage in DocsSection and added tests to cover search, sorting, and grouping features.
Bug Fixes
Tests