-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Feat/docs section improvements #6822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Implemented debounced search to filter docs. Added sorting options by status, name, or URL. Introduced grouping by domain or category with collapsible sections. Improved user experience by providing a clear, flexible interface for managing large documentation sets.
Provides a reusable debounce function to delay execution after user actions. Useful for search implementations and event handler optimizations.
Tests cover search functionality, sorting options, grouping logic, collapsible groups, empty states, and debounce behavior. Ensures stable and reliable implementation of DocsSection improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lint/build errors appear valid, can't build locally either. Seems like the file might have been corrupted or something?
Thanks for the PR though, this will be a nice improvement!
(Reproduced and fixed this.) Please review it, do provide feedback and if any changes are required. |
I don't think you've resolved the lint/build errors I mentioned? I can't review until those are fixed since I can't build. |
I've investigated the lint/build errors you mentioned. The issues are not coming from the changes in this PR, but from missing dependencies and TypeScript configuration problems in the main branch. ✅ This PR's files are clean: The modified files pass all checks:cd gui ❌ The build errors are from missing dependencies: None of these errors are in the files modified by this PR. |
Description
Enhances the DocsSection component to better handle growing documentation lists by adding search, sorting, and grouping capabilities. This addresses issue #6075 where users reported difficulty managing large numbers of documentation sources.
Key improvements:
• Search: Added debounced search input to filter docs by name or URL
• Sorting: Added dropdown to sort by status (indexing, failed, complete), name, or URL
• Grouping: Added dropdown to group docs by domain or category with collapsible sections
• UX: Empty state when no results match search, clear search button, auto-expand groups when searching
Checklist
I've read the contributing guide
The relevant docs, if any, have been updated or created
The relevant tests, if any, have been updated or created
Tests
Added comprehensive test suite (DocsSection.test.tsx) covering:
• Search functionality with debouncing
• Sorting by status, name, and URL
• Grouping by domain and category
• Collapsible group behavior
• Empty state handling
• Auto-expansion of groups when searching
• Edge cases like empty docs list
The tests ensure all new features work correctly and maintain backwards compatibility with existing functionality.
Summary by cubic
Improved the DocsSection component by adding debounced search, sorting, and grouping to help users manage large documentation lists more easily. This addresses issue #6075 by making it faster to find, organize, and review documentation sources.
New Features
Tests