Report _all_ lint failures, and fix the outstanding ones #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
storage
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 31, 2025
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6465 |
1 task
Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Otherwise, a CI run reports 3 issues, we fix them, and the CI run reports _next_ 3 issues. That's a waste of time all around, and it does not allow judging the scale of the issue. Signed-off-by: Miloslav Trmač <[email protected]>
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 31, 2025
Luap99
approved these changes
Nov 3, 2025
| path: libimage | ||
| text: LookupImage | ||
|
|
||
| issues: |
There was a problem hiding this comment.
+1 I did this in podman a long time ago, no idea why they choose such default really
containers/podman@93c35a7
It always just leads to the wrong assumption of let me just fix these three issues really quick.
There was a problem hiding this comment.
LGTM
even though I'm a day late and a dollar short for this review.
Thanks @mtrmac !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
golangci-lintdoes not report all failures if there are too many, or too many duplicates.So, e.g. in #425 , we see some failures, fix them ( #427 ) — and then there are more failures to fix.
Avoid that waste by reporting all failures immediately; and fix the outstanding ones.
@TomSweeneyRedHat PTAL