Merge pull request #429 from mtrmac/lint-all

Report _all_ lint failures, and fix the outstanding ones

Author: Luap99

common/.golangci.yml

@@ -87,3 +87,7 @@ linters:
           - contextcheck
         path: libimage
         text: LookupImage
+
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0

common/libimage/platform.go

@@ -25,6 +25,7 @@ const (
 
 // NormalizePlatform normalizes (according to the OCI spec) the specified os,
 // arch and variant. If left empty, the individual item will be normalized.
+//
 // Deprecated: new code should call libimage/platform.Normalize() instead.
 func NormalizePlatform(rawOS, rawArch, rawVariant string) (os, arch, variant string) {
 	return platform.Normalize(rawOS, rawArch, rawVariant)

common/libnetwork/types/network.go

@@ -322,6 +322,7 @@ type PortMapping struct {
 }
 
 // OCICNIPortMapping maps to the standard CNI portmapping Capability.
+//
 // Deprecated: Do not use this struct for new fields. This only exists
 // for backwards compatibility.
 type OCICNIPortMapping struct {

common/pkg/config/config.go

@@ -248,6 +248,7 @@ type ContainersConfig struct {
 	UserNS string `toml:"userns,omitempty"`
 
 	// UserNSSize how many UIDs to allocate for automatically created UserNS
+	//
 	// Deprecated: no user of this field is known.
 	UserNSSize int `toml:"userns_size,omitempty,omitzero"`
 }
@@ -558,6 +559,7 @@ type EngineConfig struct {
 	// PodmanshTimeout is the number of seconds to wait for podmansh logins.
 	// In other words, the timeout for the `podmansh` container to be in running
 	// state.
+	//
 	// Deprecated: Use podmansh.Timeout instead. podmansh.Timeout has precedence.
 	PodmanshTimeout uint `toml:"podmansh_timeout,omitempty,omitzero"`
 }

common/pkg/config/default.go

@@ -191,6 +191,7 @@ const (
 	// DefaultShmSize is the default upper limit on the size of tmpfs mounts.
 	DefaultShmSize = "65536k"
 	// DefaultUserNSSize indicates the default number of UIDs allocated for user namespace within a container.
+	//
 	// Deprecated: no user of this field is known.
 	DefaultUserNSSize = 65536
 	// OCIBufSize limits maximum LogSizeMax.

image/.golangci.yml

@@ -16,3 +16,7 @@ linters:
       - comments
       - common-false-positives
       - std-error-handling
+
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0

storage/.golangci.yml

@@ -18,3 +18,7 @@ linters:
         - all
         - -ST1003 # https://staticcheck.dev/docs/checks/#ST1003 Poorly chosen identifier.
         - -QF1008 # https://staticcheck.dev/docs/checks/#QF1008 Omit embedded fields from selector expression.
+
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0