Skip to content

fix: ensure install prefix is an absolute path (#1037) #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure install prefix is an absolute path (#1037) #1189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions crates/rattler/src/install/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,10 +267,8 @@ pub async fn link_package(
options: InstallOptions,
) -> Result<Vec<prefix_record::PathsEntry>, InstallError> {
// Determine the target prefix for linking
let target_prefix = options
.target_prefix
.as_deref()
.unwrap_or(target_dir)
let target_prefix = std::path::absolute(options.target_prefix.as_deref().unwrap_or(target_dir))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to use dunce to ensure paths are not in unc format on windows.

.map_err(InstallError::FailedToCreateTargetDirectory)?
.to_str()
.ok_or(InstallError::TargetPrefixIsNotUtf8)?
.to_owned();
Expand Down
Loading