fix: ensure install prefix is an absolute path (#1037) #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Mar 24, 2025
| .target_prefix | ||
| .as_deref() | ||
| .unwrap_or(target_dir) | ||
| let target_prefix = std::path::absolute(options.target_prefix.as_deref().unwrap_or(target_dir)) |
There was a problem hiding this comment.
We might have to use dunce to ensure paths are not in unc format on windows.
|
There is also #1155 that introduces a new |
Maybe it should be fixed there, then... maybe in |
|
#1155 was finally merged, could you maybe update your code? |
|
@calebzulawski Could you take another look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure install prefix (and therefore substitution paths) are absolute to fix #1037