Skip to content

Conversation

@sodre
Copy link
Member

@sodre sodre commented Jul 19, 2018

License file was added to the feedstock and an upstream PR was created to fix this issue.

cf: jamescasbon/PyVCF#295

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyvcf) and found some lint.

Here's what I've got...

For recipes/pyvcf:

  • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

@sodre
Copy link
Member Author

sodre commented Jul 20, 2018

@conda-forge/bioconda-recipes, please advise how to proceed with pyvcf package.

The bioconda community prefers for the package to stay in bioconda, and I need to package apache-beam and others for airflow which has a install-requirement on pyvcf.

As agreed to in the bioconda/bioconda-recipes#9979 PR I added everyone in that thread as a `recipe-maintainer`. The order is alphabetical.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyvcf) and found it was in an excellent condition.

@sodre
Copy link
Member Author

sodre commented Jul 28, 2018

@bgruening, this is ready to merge.

FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this file. This is not necessary since the LICENSE file is already in the repository and being package

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not. Please see my initial post with a reference to the PR for changing the MANIFEST.in file.

Until then the license file should stay here.

@bgruening bgruening merged commit 80b0cc0 into conda-forge:master Jul 28, 2018
@bgruening
Copy link
Contributor

Thanks!

@sodre sodre deleted the pyvcf branch December 22, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants