Skip to content

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Jul 12, 2025

  1. Removed unnecessary content_types field (not used in V1 nodes)
  2. Switched to using the UploadType enum to specify the uploaded file type for COMBO inputs

Change number 2 is required to port audio and video nodes to the V3

@bigcat88 bigcat88 changed the title V3 Nodes: make generic upload parameters for io.Combo.Input [V3] make generic upload parameters for io.Combo.Input Jul 12, 2025
Copy link
Collaborator

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, nice catch. On the frontend, we are also supporting animated_image_upload for apng and animated webp uploads.

Also, we have allow_batch to specify that the upload allows multiple files at once, which will be sent as a comma-separated list of filepaths.

See all the combo input options the frontend reads: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/schemas/nodeDefSchema.ts#L74-L85

@Kosinkadink Kosinkadink merged commit 8f7e273 into comfyanonymous:v3-definition Jul 14, 2025
1 check failed
@Kosinkadink
Copy link
Collaborator

looks good, merging

@bigcat88 bigcat88 deleted the v3/io/uploadtype branch July 15, 2025 14:33
@Kosinkadink Kosinkadink added the v3 label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants