Skip to content

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Jul 13, 2025

  1. Sorted imports in ui, io and new added nodes file.
  2. Fixed ruff warnings by adding # noqa to the V1 nodes code in io.py
  3. Commented out code with print that was used for fast local testing to eliminate ruff warnings.
  4. Implemented ui.PreviewAudio class
  5. Fully ported nodes_audio.py to V3 with ConditioningStableAudio_V3, EmptyLatentAudio_V3, LoadAudio_V3, PreviewAudio_V3, SaveAudioMP3_V3, SaveAudioOpus_V3, SaveAudio_V3, VAEDecodeAudio_V3, VAEEncodeAudio_V3
  6. Added empty __init__.py file to comfy_api.v3 folder to eliminate future linter complaints that ui.py imports io file from v3 and io which is a core Python package with a BytesIO class.

Tested all nodes except ConditioningStableAudio_V3 and VAEEncodeAudio_V3.

All V3 nodes during tests were renamed to V1 names(and V1 nodes was commented out) as frontend has a strict requirement for node_id:
Screenshot from 2025-07-15 11-05-40

Screen from testing EmptyLatentAudio and VAEDecodeAudio:
Screenshot from 2025-07-15 13-06-29

@bigcat88 bigcat88 marked this pull request as draft July 15, 2025 06:48
@bigcat88 bigcat88 marked this pull request as ready for review July 15, 2025 10:12
@bigcat88 bigcat88 changed the title [V3] nodes: LoadAudio and PreviewAudio [V3] nodes: basic Audio nodes Jul 15, 2025
@Kosinkadink
Copy link
Collaborator

looks good, merging

@Kosinkadink Kosinkadink merged commit f687f8a into comfyanonymous:v3-definition Jul 15, 2025
1 check passed
@bigcat88 bigcat88 deleted the v3/nodes/audio branch July 15, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants