Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to nightly-2024-12-15 #144

Merged
merged 12 commits into from
Jan 2, 2025

Conversation

willcrichton
Copy link
Collaborator

@willcrichton willcrichton commented Dec 16, 2024

Also...
closes #129
closes #146

@@ -220,10 +221,10 @@ impl<A: AquascopeAnalysis> rustc_driver::Callbacks for AquascopeCallbacks<A> {
config.override_queries = Some(borrowck_facts::override_queries);
}

fn after_expansion<'tcx>(
fn after_analysis<'tcx>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, from what I can tell, this is not called if the analysis fails. It should be after_expansion because we bypass the borrow checker.

@willcrichton willcrichton merged commit f830872 into cognitive-engineering-lab:main Jan 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants