Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch 4.2 code block examples with permission annotations use path in tooltips instead of place #146

Closed
ejohnso49 opened this issue Nov 21, 2024 · 2 comments · Fixed by #144

Comments

@ejohnso49
Copy link

URL to the section(s) of the book with this problem:

Description of the problem:
In previous issues/PRs (#176 cognitive-engineering-lab/rust-book#211) the wording was changed to move to the use of place over path, however these same changes were not applied to the components used to annotated the code blocks. In particular the tooltips still refer to paths instead of places so it felt confusing to see that term when it is not used elsewhere in this chapter.

Suggested fix:
Change the tooltips and any parts of the permission annotation components to use place instead of path. I really like the annotations, I just got confused with the mixed use of path and place

@willcrichton willcrichton transferred this issue from cognitive-engineering-lab/rust-book Jan 1, 2025
@willcrichton
Copy link
Collaborator

Thanks for pointing this out. We'll update this in Aquascope.

@willcrichton
Copy link
Collaborator

Will be fixed in #144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants